-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(deps): updates tests to CRS v4.5 and Albedo as backend #161
Conversation
1.0.x requires CRS 4.5 Co-authored-by: Matteo Pace <pace.matteo96@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
#152 has been merged updating back go-ftw to v1.0.3
.
CRS v4.3 still comes with the old test format expected to be run with go-ftw 0.6.4
.
I don't get it from a go-ftw standpoint, but running old test formats with the latest go-ftw just leads to all the tests passed.
Run with go-ftw 0.6.4
:
➕ run 3714 total tests in 17.949088553s
⏭ skipped 6 tests
☝ ignored 95 tests
👎 15 test(s) failed to run: ["920201-2" "920202-2" "920290-4" "930110-7" "951220-2" "951230-2" "951240-2" "953101-1" "953101-2" "953101-3" "953101-4" "953101-5" "955100-1" "955100-2" "955100-3"]
Error: failed 15 tests
Run with go-ftw 1.0.3
:
➕ run 3904 total tests in 8.533989878s
⏭ skipped 0 tests
☝ ignored 95 tests
🎉 All tests successful!
This PR requires either directly bumping CRS to 4.5 and also updating the backend to Albedo, or stick with the previous go-ftw. I'm working on the first option
Quality Gate passedIssues Measures |
Some numbers about the CRS tests ( Caddy 🚀 53 excluded tests are now working. Overall we got a good -40 failing tests, but more work is definitely needed to chase down the to-be-investigated ones. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome work!
No description provided.